Rebase kcp 0.32#321
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Rebases the repo’s kcp/kubernetes dependency stack to kcp v0.32 (and the corresponding kcp-dev Kubernetes staging forks), updating standalone provider modules and the shared provider SDK to match. It also tightens bootstrap behavior by allowing embedded-but-not-applied YAML files, and improves kuery’s user-facing error handling to avoid leaking internal store/driver details.
Changes:
- Bump root module + standalone provider modules to kcp v0.32.0 ecosystem deps (kcp, sdk, multicluster-provider, apimachinery/v2) and refresh
go.sumaccordingly. - Add
SkipFilessupport to bootstrap helpers and use it to avoid applying an embedded-but-not-intended APIExport YAML. - Adjust kuery query API error handling: return 400 for validation errors, log internal failures, and return 500 with a generic message.
Reviewed changes
Copilot reviewed 10 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| providers/quickstart/go.mod | Updates indirect deps and keeps k8s modules pinned to the kcp staging forks. |
| providers/quickstart/go.sum | Refreshes sums to match the updated quickstart module dependency graph. |
| providers/kuery/queryapi/handler.go | Improves error classification/logging and avoids leaking driver internals to callers. |
| providers/kuery/go.mod | Updates kuery provider to kcp v0.32-related versions and adjusts replaces. |
| providers/kuery/go.sum | Refreshes sums for the updated kuery provider dependency set. |
| providers/infrastructure/go.mod | Updates infrastructure provider to kcp v0.32-related versions and simplifies replaces. |
| providers/infrastructure/go.sum | Refreshes sums for the updated infrastructure provider dependencies. |
| providers/code/go.mod | Updates code provider to kcp v0.32 stack and aligns k8s replacements to new kcp-dev staging SHAs. |
| providers/code/go.sum | Refreshes sums for the updated code provider dependency graph. |
| providers/app-studio/go.mod | Updates app-studio provider deps (including k8s staging fork pins) to match the kcp v0.32 rebase. |
| providers/app-studio/go.sum | Refreshes sums for the updated app-studio provider dependencies. |
| provider-sdk/go.mod | Updates shared provider SDK indirect deps and k8s staging fork pins to the new kcp-dev kubernetes SHA set. |
| provider-sdk/go.sum | Refreshes sums for the updated provider SDK dependency graph. |
| pkg/util/confighelpers/confighelpers.go | Adds SkipFiles option and wires it into embedded-YAML bootstrap application. |
| pkg/hub/kcp/bootstrap.go | Uses SkipFilesOption to avoid applying an embedded APIExport YAML that is intended only as generator input. |
| go.mod | Rebase root module to kcp v0.32 stack; updates k8s versions/pins and consolidates apimachinery/v2 pin rationale. |
| go.sum | Refreshes root sums to match the new kcp/kubernetes staging dependency graph and related bumps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase