Add support for unix domain sockets - #109
Merged
Merged
Conversation
Signed-off-by: Alec Fenichel <alec.fenichel@transnexus.com>
Tony133
requested changes
Sep 4, 2026
Tony133
left a comment
Tony133
left a comment
Member
There was a problem hiding this comment.
LGTM
Could you also update the README? It currently says that the returned array includes the socket address and that index 0 is the socket address. This is no longer accurate for Unix domain sockets after this change, since no socket address is included and the returned array can be empty.
Signed-off-by: Alec Fenichel <alec.fenichel@transnexus.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for unix domain sockets (i.e.,
req.socket.remoteAddressisundefined).Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct