[CDTOOL-1193] Support for Logging Endpoint Errors#1721
Conversation
298e131 to
020be64
Compare
kpfleming
left a comment
There was a problem hiding this comment.
This is fine as-is, but I've suggested some minor improvements.
|
|
||
| // RootCommand is the parent command for all subcommands in this package. | ||
| // It should be installed under the primary root command. | ||
| type RootCommand struct { |
There was a problem hiding this comment.
This is really minor, but since there aren't any subcommands all references to RootCommand should be DebugCommand.
There was a problem hiding this comment.
It looks like the linter is throwing an error now due to the naming convention:
pkg/commands/service/logging/debug/root.go:28:6: exported: type name will be used as debug.DebugCommand by other packages, and that stutters; consider calling this Command (revive)
type DebugCommand struct {
Thoughts @kpfleming - should we revert it back or see if a override can be used?
There was a problem hiding this comment.
Added an override in f09a9c3 for the time being.
There was a problem hiding this comment.
It's actually fine to just call it Command too, since it is the only command in this package.
There was a problem hiding this comment.
Maybe we'll ask @anthony-gomez-fastly to make the deciding call on this one :)
Also removed the 'batch' export.
Change summary
This PR adds support for the
service logging debugcommands, which streams logging endpoint errors.All Submissions:
New Feature Submissions:
Changes to Core Features:
Example Output:
Note: Claude Code was leveraged to build this feature