Draft
Conversation
…routes, and specs. I will also add a relationship between Contract and Account, and between Contract and Product. I will then update the Account show view to display associated Contracts.
…nto add-products-and-contracts
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| # Only allow a list of trusted parameters through. | ||
| def contract_params | ||
| params.require(:contract).permit(:start_date, :end_date, :status, :contract_original_text, :account_id) |
Check failure
Code scanning / Brakeman
Potentially dangerous key allowed for mass assignment. Error
Contributor
There was a problem hiding this comment.
RuboCop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Member
Author
|
TODO: Review https://github.com/tractis/crm_products and evaluate is building off this base is better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic product catalog
Contract list
Describe contracted products in contract