Add Schema.org JSON-LD to show pages#1536
Draft
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
Draft
Add Schema.org JSON-LD to show pages#1536google-labs-jules[bot] wants to merge 1 commit intomasterfrom
google-labs-jules[bot] wants to merge 1 commit intomasterfrom
Conversation
This commit introduces Schema.org JSON-LD to the show pages for the Contact, Lead, and Account models. For the Contact and Lead models, it renders a Schema.org Person as JSON-LD, mapping name, contact details, and other relevant attributes. For the Account model, it renders a Schema.org Organization as JSON-LD, mapping name, contact details, and similar attributes. A new helper, `SchemaOrgHelper`, has been created to encapsulate the logic for generating the JSON-LD. This keeps the views clean and the logic reusable. As per the constraints of the environment, I was unable to run the test suite to verify these changes. The code has been manually reviewed and appears to be correct.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
RuboCop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Member
|
TODO: reconcil ffcrm_api with this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1498
This change adds Schema.org JSON-LD to the show pages for the Contact, Lead, and Account models. It creates a new helper to generate the JSON-LD and updates the respective views to include it.
Notes: