-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(memory): Graphnosis provider UI, MCP install, and onboarding #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,5 +58,7 @@ export default { | |
| openviking: | ||
| "Session-managed memory with tiered retrieval and knowledge browsing", | ||
| byterover: "Persistent knowledge tree with tiered retrieval via brv CLI", | ||
| graphnosis: | ||
| "Local encrypted engram graph — auto-prefetch, recall, remember. Requires Graphnosis app (no API key)", | ||
|
Comment on lines
+61
to
+62
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a local Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch — fixed in 847ed5b. |
||
| }, | ||
| } as const; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MCP config writer preserves
${HOME}/.graphnosis/mcp.sockas a literal argv value, and stdio servers launched directly do not receive shell expansion. Unless the relay explicitly expands this syntax itself, the installed server cannot find the user's socket even though installation reports success; the value is also not portable to Windows.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hermes-agent interpolates
${VAR}placeholders in MCP server config before spawn (tools/mcp_tool.py, "Recursively resolve ${VAR} placeholders"), so on macOS/Linux${HOME}resolves to the real socket path — this matches the convention the other Graphnosis surfaces already use (the relay's own README and the prior catalog preset). You're right that it's not robust on Windows, whereHOMEis typically unset and the placeholder would stay literal. That's a pre-existing, cross-surface gap rather than something specific to this PR; the proper fix is to have@graphnosis/mcp-relaydefault toos.homedir()/.graphnosis/mcp.sockwhen no path arg is given, which I'm tracking on the relay package. Keeping${HOME}here for consistency with the existing providers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: the relay fix has landed.
@graphnosis/mcp-relay@1.0.3(published) now expands a leading~and${HOME}/$HOMEitself viaos.homedir()(and defaults to~/.graphnosis/mcp.sockwhen no path arg is given), so the socket path resolves correctly even when the host spawns the server without a shell — including on Windows whereHOMEis unset. The${HOME}value written here is therefore portable once users are on relay ≥1.0.3.