ci: fix clippy check spelling and labeler failures - #779
Conversation
2f17706 to
1974e1a
Compare
|
@mcattamoredhat This is probably annoying, but could you split the changes into separate commits for each CI check you have fixed? |
| toolchain: stable | ||
| components: clippy | ||
| - run: cargo clippy -- -D warnings -D clippy::panic -D clippy::todo | ||
| - run: cargo clippy -- -D clippy::panic -D clippy::todo |
There was a problem hiding this comment.
Since we don't have Rust veterans in the team I would encourage to maintain clippy failing on warnings, we need more learning opportunities
There was a problem hiding this comment.
Ok @7flying I understand. These warnings are related to the older format string syntax usage in rs files
I.e. https://github.com/fdo-rs/fido-device-onboard-rs/blob/main/util/src/servers/mod.rs#L73
format!("{}.yml", guid)
Instead of
format!("{guid}.yml")
There is more than one file using this syntax. Thus, should we change all of them (despite those changes wouldn't be related to Clippy command) in a separated PR?
There was a problem hiding this comment.
@mcattamoredhat I would run cargo clippy -- -D clippy::panic -D clippy::todo (as we do in the CI job), find all the warnings/panics and fix them. Then repeat the process until all the errors are fixed.
Sure, no problem @miabbott! |
| ot | ||
| marshalling | ||
| te | ||
| blacklist |
There was a problem hiding this comment.
this should be a separate commit.
| possible stability impact: | ||
| - libfdo-data/fdo_data.h | ||
| - libfdo-data/libfdo-data-go.doc | ||
| "possible stability impact": |
There was a problem hiding this comment.
Again a separate commit, generally each fix should be independent, make it easier for bisect and review.
|
Closing this PR because the work has been splitted into separated commits. |
@mcattamoredhat For future reference, you can bundle multiple commits into a single PR. |
4 participants
In order to fix Clippy issue, the strict warning treatment has been removed.
Some exceptions have been added to
.github/spellcheck-ignorefile..github/labeler.ymlfile has been updated to align with changes of Pull Request labeler v5 actions/labeler@v5 (add missing quotes and use the changed-files structure)