Skip to content

ci: fix clippy check spelling and labeler failures #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcattamoredhat wants to merge 1 commit into from
Closed

ci: fix clippy check spelling and labeler failures #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
possible stability impact:
- libfdo-data/fdo_data.h
- libfdo-data/libfdo-data-go.doc
"possible stability impact":

@nullr0ute nullr0ute Jul 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again a separate commit, generally each fix should be independent, make it easier for bisect and review.

- changed-files:
- any-glob-to-any-file: "libfdo-data/fdo_data.h"
- any-glob-to-any-file: "libfdo-data/libfdo-data-go.doc"
3 changes: 3 additions & 0 deletions .github/spellcheck-ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@ childs
ot
marshalling
te
blacklist

@nullr0ute nullr0ute Jul 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a separate commit.

msdos
ro
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
with:
toolchain: stable
components: clippy
- run: cargo clippy -- -D warnings -D clippy::panic -D clippy::todo
- run: cargo clippy -- -D clippy::panic -D clippy::todo

@7flying 7flying Jul 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have Rust veterans in the team I would encourage to maintain clippy failing on warnings, we need more learning opportunities

@mcattamoredhat mcattamoredhat Jul 7, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok @7flying I understand. These warnings are related to the older format string syntax usage in rs files

I.e. https://github.com/fdo-rs/fido-device-onboard-rs/blob/main/util/src/servers/mod.rs#L73
format!("{}.yml", guid)
Instead of
format!("{guid}.yml")

There is more than one file using this syntax. Thus, should we change all of them (despite those changes wouldn't be related to Clippy command) in a separated PR?

@miabbott miabbott Jul 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcattamoredhat I would run cargo clippy -- -D clippy::panic -D clippy::todo (as we do in the CI job), find all the warnings/panics and fix them. Then repeat the process until all the errors are fixed.


build_and_test:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion util/src/servers/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ pub fn settings_per_device(guid: &str) -> Result<ServiceInfoSettings> {

let path_per_device_store = match settings.device_specific_store_driver {
StoreConfig::Directory { mut path } => {
let file_name = format!("{}.yml", guid);
let file_name = format!("{guid}.yml");
path.push(file_name);
path.to_string_lossy().into_owned()
}
Expand Down
Loading