Support libcryptsetup-rs 0.15 - #805
Open
musicinmybrain wants to merge 2 commits into
Open
Conversation
This is required for a git checkout to compile at all on Fedora 44.
Do not leave its version open-ended; SemVer-bound it instead.
musicinmybrain
force-pushed
the
libcryptsetup-rs-0.15
branch
from
May 19, 2026 07:03
46f76dd to
bbbd3fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, I upgraded
tss-apifrom 7.6 to 7.7. This was required in order to compile at all on Fedora 44, fixing a long list of errors similar to:Then, I upgraded
libcryptsetup-rsfrom>= 0.11.2to0.15. Downstream in Fedora, thefido-device-onboardpackage built fine with 0.13, but fails to build from source with 0.15 due toLooking at the relevant documentation, I confirm that the
luksfield inCryptParamsReencryptwas made optional between 0.13 and 0.15.Considering that all of the fields of the
CryptParamsLuks2are zero orNone, and that I don’t see any obvious evidence that LUKS is actually in use here, I made an educated guess that this semantically means “no LUKS2 options,” and it’s correct to replace the whole structure withNonerather than wrapping it inSome.fido-device-onboard-rs/client-linuxapp/src/reencrypt/mod.rs
Lines 80 to 89 in 29cedcc
After this PR,
cargo testpasses again, at least in theclient-linuxappsubdirectory.