Feat: Use Git Tags for release number calculation & changelog processing#397
Open
LordAlfredo wants to merge 1 commit into
Open
Feat: Use Git Tags for release number calculation & changelog processing#397LordAlfredo wants to merge 1 commit into
LordAlfredo wants to merge 1 commit into
Conversation
Rpmautospec has no way to know the actual release history and cannot verify its calculated releasenum and changelog match reality. By using git tags, we can add metadata to the git repo to hint the real release history, enabling Rpmautospec to correctly calculate the exact next release number (even if it's a rebuild!) and construct the changelog based on historical N-V-R data. By using tag namespaces, we can also support multiple build systems and OSes from the same git repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rpmautospec has no way to know the actual release history and cannot verify its calculated releasenum and changelog match reality. By using git tags, we can add metadata to the git repo to hint the real release history, enabling Rpmautospec to correctly calculate the exact next release number (even if it's a rebuild!) and construct the changelog based on historical N-V-R data. By using tag namespaces, we can also support multiple build systems and OSes from the same git repos.
By default, Rpmautospec will continue to use existing behavior. The new git tag path will only be used if a tag namespace parameter is entered.
This includes a few pieces:
I have tested this by e.g. tagging packages with unresolvable Rawhide merges, such as mesa, and comparing original behavior, tag-only, and accumulation mode. While I have not tested every package using Rpmautospec, thus far I have seen zero processing failures with tags. Within Amazon, this also solves our issues with merges from each upstream (not just from Fedora).
I have standardized handling of the namespaced format by extending behavior in -core
I have bumped minor version given this is new functionality/enhancement and to better delineate dependency versions across all Rpmautospec component packages.