merge greenboot-success.target inside heathcheck service - #63
Merged
Conversation
say-paul
force-pushed
the
systemd-service-unification
branch
from
July 9, 2025 09:03
f1c50c4 to
a639c4c
Compare
No need to manually enable greenboot-success target CI tests updated
say-paul
force-pushed
the
systemd-service-unification
branch
from
July 10, 2025 06:09
f93626b to
cec0ce5
Compare
say-paul
force-pushed
the
systemd-service-unification
branch
2 times, most recently
from
July 10, 2025 12:18
0f2e3f1 to
74a4d3d
Compare
djach7
reviewed
Jul 16, 2025
Member
Author
|
CI pased for 10 bootc : https://artifacts.osci.redhat.com/testing-farm/8982381f-3b67-454b-99cc-e054c4c92406/ |
Member
Author
|
tested rpm-ostree locally. |
mmartinv
approved these changes
Jul 21, 2025
mmartinv
left a comment
mmartinv
left a comment
Contributor
There was a problem hiding this comment.
LGTM
(Although not sure why the build_and_test action is warning about unused imports and functions)
Member
Author
its because there are two branches of testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enabling greenboot-healthcheck.service will auto enable greenboot-success.target , so user does not need to enable it manually.