Skip to content

Dev - 15026: Download Center: COVID-19 filters selections do not auto remove when going from a B file to an A file #5348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anjenkin merged 2 commits into from
Jun 12, 2026
Merged

Dev - 15026: Download Center: COVID-19 filters selections do not auto remove when going from a B file to an A file #5348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75d3946
fix enabled state
jdhfrb Jun 11, 2026
dcb2412
fix disabled expanded state.
jdhfrb Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/js/components/bulkDownload/DEFCheckboxTreeDownload.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ const DEFCheckboxTreeDownload = ({
detailsDisplay(validDefCodes);
}, [validDefCodes]);

useEffect(() => {
if (isDisabled && defCodes.length){
dispatch(setDefCodes(type, []));
}
}, [defCodes, dispatch, isDisabled, type])

return (
<div className="def-code-filter-download">
{isLoading && loadingIndicator }
Expand Down
12 changes: 10 additions & 2 deletions src/js/components/sharedComponents/checkbox/AccordionCheckbox.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,20 @@ const AccordionCheckbox = ({
};

useEffect(() => {
if (isExpanded) {
if (isDisabled && expandedCategories?.length) {
// have to check expandeCategories instead of isExpanded.
// isExpanded might not be known by parent
// collapse expandedCategories
expandedCategories.forEach((ec) => toggleExpanded({id: ec}));

}
else if (isExpanded) {
const category = filterCategoryMapping.find((item) => item.id === selectedCategory);
toggleExpanded(category);
}

// eslint-disable-next-line react-hooks/exhaustive-deps
}, [filterCategoryMapping, isExpanded, selectedCategory]);
}, [filterCategoryMapping, isExpanded, selectedCategory, isDisabled]);

const handleTextInputChange = (e) => {
setSearchString(e.target.value);
Expand Down
Loading