Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description:
Once the strategy to merge the files succeeds we know the MachO files we've generated can run on both arm64 and x64. One interesting quirk here is @electron/universal only modifies the temp folder MachO files. It doesn't touch the arm64 folder.
That becomes a problem when the arm64 folder is compared with the temporary folder.
@electron/universalhas modified the MachO files in the temp folder. So they should certainly be different from the ones in the arm64 folder.Solution Description:
This PR ads a set of files that
@electron/universalmerged, and then checks the results of the compare to specifically check that files other than the merged MachO files are different.