Fix P2/P3 rerun-example follow-up beads + version bumps - #168
Merged
Conversation
- Fix rerun example imports (ferritin_bevy + load_model) so it compiles after the ferritin-structure-mesh -> ferritin-bevy rename (ferritin-3g7, a P1 blocker for ferritin-s0s below) - Add CI cargo-check coverage for all-targets, rerun-gated ferritin-bevy, and the rerun example itself (gated to push-to-main, since it pulls re_viewer) so this class of regression fails CI instead of only appearing in the editor (ferritin-s0s) - Purge remaining ferritin-structure-mesh references: drop the empty crate shell dir, stale .gitignore entry, stale deps.txt dump, and fix dead links in crates/Readme.md and docs/index.qmd (ferritin-eop) - Add .vscode/settings.json enabling the 'rerun' cargo feature for rust-analyzer so it stops reporting phantom unresolved-import errors on the rerun example (ferritin-5n5) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ferritin_structure_mesh/load_structureimports so it compiles again (ferritin-3g7, a P1 blocker discovered while working ferritin-s0s)cargo checkcoverage for all-targets, rerun-gatedferritin-bevy, and the rerun example itself (gated to push-to-main since it pullsre_viewer), so this class of regression fails CI instead of silently rotting (ferritin-s0s, P2)ferritin-structure-meshreferences: empty crate shell dir, stale.gitignoreentry, staledeps.txtdump, and dead links incrates/Readme.md/docs/index.qmd(ferritin-eop, P3).vscode/settings.jsonenabling thereruncargo feature so rust-analyzer stops reporting phantom unresolved-import errors on the rerun example (ferritin-5n5, P3)Note:
ferritin-5xd("Define stable WASM and GPU boundary for molecular columns", P2) is intentionally left open — it requires net-new architecture (no wasm-bindgen/wgpu exists in the workspace today) rather than a fix, so it needs its own scoping pass.Test plan
cargo build— cleancargo test --verbose— all tests passcargo check --workspace --all-targets— clean (warnings only)cargo check -p ferritin-bevy --features rerun— cleancargo check -p ferritin-examples --features rerun --example rerun— clean🤖 Generated with Claude Code