test: fix timing issue in device CA rendezvous trust test - #17
Merged
knecasov merged 1 commit intoJun 23, 2026
Merged
Conversation
Move the "add wrong Device CA cert to rendezvous" step before sending the ownership voucher to the owner. This ensures the rendezvous server has the wrong certificate in its trust store when the owner performs TO0 (voucher registration). Previously, the wrong cert was added AFTER the owner had already successfully registered the voucher with the rendezvous (which had no Device CA requirements at that point). This allowed TO0 to succeed when it should have failed, making the test ineffective. With this fix, when the owner performs TO0, the rendezvous will verify the voucher's device certificate chain against the wrong CA and correctly reject it. Signed-off-by: Miguel Martín <mmartinv@redhat.com> Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix timing issue in
test-device-ca-rendezvous-trust.shthat prevented proper validation of device CA certificate verification.Problem
The test was adding the wrong Device CA certificate to the rendezvous server after the owner had already performed TO0 (voucher registration). This meant:
Solution
Move the "add wrong Device CA cert to rendezvous" step before sending the ownership voucher to the owner. Now:
Changes
test/ci/test-device-ca-rendezvous-trust.shTest Plan
test-device-ca-rendezvous-trust.sh- should now fail correctly when wrong cert is used🤖 Assisted-by: Claude Code