ci: allow testing composes

[mmartinv]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the continuous integration testing infrastructure by introducing the capability to install and test RPM packages directly from compose repositories. This change provides greater flexibility in testing environments, allowing for validation against official builds and different distribution channels, which is crucial for robust CI/CD pipelines.

Highlights

• Compose Repository Support: Added a new install_from_compose function to enable installation of RPM packages directly from compose repositories for Fedora, CentOS, and RHEL operating systems.
• Conditional RPM Installation: Modified the install_client and install_server functions to conditionally install RPMs from either a COPR repository or a compose repository, based on the USE_COMPOSE environment variable.
• RPM Package Lists: Introduced dedicated shell variables (go_fdo_server_rpms and go_fdo_client_rpms) to define the lists of server and client RPMs, improving maintainability and consistency across installation and uninstallation routines.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• test/rpm/utils.sh
  • Added install_from_compose function to handle RPM installation from compose repositories.
  • Updated install_client to support installation from compose repositories based on USE_COMPOSE.
  • Updated install_server to support installation from compose repositories based on USE_COMPOSE.
  • Modified uninstall_client and uninstall_server to utilize new RPM package list variables.
  • Defined go_fdo_server_rpms and go_fdo_client_rpms variables for consistent package referencing.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a valuable feature for testing against composes by adding an install_from_compose function and integrating it into the existing installation logic. The use of variables for RPM package lists is a good improvement for maintainability. However, I've identified a couple of issues that need to be addressed: a typo in a default variable assignment and an unconditional package removal that should be conditional to avoid problems in CI environments. Please see the detailed comments for suggestions.

[github-actions]

go-test-coverage report

Total test coverage: 63.8% (1402/2197)

No coverage changes in any files compared to the base.