v2 preparation - #246
Draft
runcom wants to merge 10 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the to0Client interface and its implementations to support a new delegateName parameter in the RegisterBlob method. Additionally, it introduces a replace directive in go.mod pointing to a personal fork of go-fdo. Feedback highlights that using a personal fork in go.mod can cause build and maintainability issues for downstream consumers, and suggests avoiding hardcoding the delegateName to an empty string in RegisterRvBlob by either exposing it in the function signature or documenting the limitation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
runcom
force-pushed
the
prep-v2
branch
4 times, most recently
from
July 21, 2026 07:23
f93542d to
20c5ef6
Compare
Update replace directive to use github.com/runcom/go-fdo@a65532ef9792 which includes: - P0: Fixed FDO 2.0 service info exchange - P1: Fixed KEX parameter and HTTP version validation - P2: Version context injection, ReplacementHmac type, RvDelegate field - Removed delegation from FDO 1.1 (delegation is FDO 2.0 only) - Fixed transport path routing for FDO 2.0 Note: Requires GONOSUMDB=* GOPROXY=direct for go mod tidy until sum.golang.org indexes the new commit. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
runcom
marked this pull request as ready for review
July 21, 2026 08:50
runcom
marked this pull request as draft
July 21, 2026 08:50
Updates go-fdo to commit 2821218 which includes: - FDO 2.0 protocol implementation (TO0, TO1, TO2) - Capability flags for version negotiation - Delegation support - Comprehensive test suite Changes: - Updated go.mod replace directive to point to runcom/go-fdo v2-new branch - Updated RegisterBlob interface to include delegateName parameter - Pass empty string for delegateName (no delegation in server yet) Build verified successfully. Signed-off-by: Antonio Murdaca <antoniomurdaca@gmail.com>
This commit adds comprehensive documentation for FDO 2.0 protocol support in go-fdo-server. The server already supports FDO 2.0 alongside FDO 1.1: - Dual protocol routes: /fdo/101/msg/ (v1.1) and /fdo/200/msg/ (v2.0) - Automatic version negotiation via capability flags - Cross-version compatibility with all client versions - Delegation protocol support (FDO 2.0 feature) Key FDO 2.0 features documented: - Message type ranges (TO0: 20-23, TO1: 30-33, TO2: 80-91) - Capability flags (Capb0SupFDO11, Capb0SupFDO20) - Delegation protocol with DelegateChain - Delegation management API endpoints - Hash binding chain (HashPrev/HashPrev2) - Additional Authenticated Data (AAD) Includes: - Configuration examples - Management API reference for delegation - Migration guide from FDO 1.1 - Monitoring and debugging tips Signed-off-by: Antonio Murdaca <runcom@redhat.com> Signed-off-by: Antonio Murdaca <antoniomurdaca@gmail.com>
Update countingClient mock to match the new RegisterBlob signature with delegateName parameter added in FDO 2.0 support. Signed-off-by: Antonio Murdaca <runcom@redhat.com> Signed-off-by: Antonio Murdaca <antoniomurdaca@gmail.com>
Update to latest v2-new (8b6a6d2) which removes omitempty from TO1 CapFlags fields, fixing CBOR field count mismatch error during TO1: error decoding TO1.HelloRV request: struct has an incorrect number of fields: has 2, expected 3 CapFlags is now always serialized, ensuring consistent 3-field struct. Signed-off-by: Antonio Murdaca <runcom@redhat.com> Signed-off-by: Antonio Murdaca <antoniomurdaca@gmail.com>
Update to a2922fa which adds TO1Options.SendCapFlags for controlling whether capability flags are sent in TO1.HelloRV messages. This enables backward compatibility with FDO 1.1-only servers while supporting FDO 2.0 clients when they explicitly request it. Signed-off-by: Antonio Murdaca <runcom@redhat.com> Signed-off-by: Antonio Murdaca <antoniomurdaca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.