Fix fdo.command args encoding - #720
Open
raihio wants to merge 4 commits into
Open
Conversation
raihio
force-pushed
the
fix_encodings
branch
from
September 22, 2025 14:42
dac64ac to
3ee59a7
Compare
raihio
force-pushed
the
fix_encodings
branch
from
September 28, 2025 13:33
fdae1c3 to
66a524f
Compare
Author
|
Added an additional change to also align the execute parameter with the specification. The Java server was sending a CBOR array but the spec requires a CBOR null. This caused a deserialization error in the Go client. I've updated the Java server to send the correct CBOR null value which resolves the incompatibility with the Go client and ensures spec compliance. |
Author
|
The Java server changes to args and execute will require a corresponding update in the C client. Happy to make the changes in client-sdk-fidoiot, have started a draft PR: fido-device-onboard/client-sdk-fidoiot#300 Please take a look @ben-krieger |
Collaborator
|
@rftemple Are you able to help review this? |
Signed-off-by: Raihan M <muhamedraihan@gmail.com>
Signed-off-by: Raihan M <muhamedraihan@gmail.com>
Signed-off-by: Raihan M <muhamedraihan@gmail.com>
raihio
force-pushed
the
fix_encodings
branch
from
February 23, 2026 17:12
f95f93a to
08c75e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #719