Sector status fixes and solidity integration test#1720
Open
ZenGround0 wants to merge 8 commits intomasterfrom
Open
Sector status fixes and solidity integration test#1720ZenGround0 wants to merge 8 commits intomasterfrom
ZenGround0 wants to merge 8 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1720 +/- ##
=======================================
Coverage 90.53% 90.53%
=======================================
Files 139 139
Lines 27693 27693
=======================================
Hits 25072 25072
Misses 2621 2621
🚀 New features to boost your workflow:
|
wjmelements
reviewed
Mar 3, 2026
Kubuxu
reviewed
Mar 4, 2026
| FilecoinCBOR.CBORBuffer memory buf = FilecoinCBOR.createCBOR(64 + statusBytes.length + auxData.length); | ||
| FilecoinCBOR.startFixedArray(buf, 3); | ||
| FilecoinCBOR.writeUInt64(buf, sectorNumber); | ||
| FilecoinCBOR.writeTextString(buf, status); |
Contributor
There was a problem hiding this comment.
Are enums transformed into text?
Contributor
Author
There was a problem hiding this comment.
nice catch and apparently dag cbor writes rust enums as raw strings?! i.e. "Active" "Faulty" "Dead"
I'll move this to integer enums.
Contributor
Author
There was a problem hiding this comment.
At the same time I'll fullfil your request for reordering Dead as 0 @wjmelements
4315cc9 to
b3d7b31
Compare
wjmelements
reviewed
Mar 20, 2026
Comment on lines
+69
to
70
| // 0x51 is IPLD CBOR codec | ||
| require(inCodec == 0x51, "Invalid codec"); |
There was a problem hiding this comment.
can it be a constant?
Suggested change
| // 0x51 is IPLD CBOR codec | |
| require(inCodec == 0x51, "Invalid codec"); | |
| require(inCodec == FilecoinCBOR.CBOR_CODEC, "Invalid codec"); |
wjmelements
reviewed
Mar 20, 2026
Comment on lines
+70
to
+71
| require_activation_success: false, | ||
| require_notification_success: false, |
Contributor
Author
There was a problem hiding this comment.
yeah that's a bit cleaner
|
Claude identified a discrepancy in error handling with the FIP: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow on to the main PR introducing sector status #1707. This follows the pattern from #1689 and introduces a solidity integration test. This appears to work but had a lot of ai in the loop and needs more validation and simplification. Additionally I think we can clean up our previous itest to extract the shared cbor and calling logic into a library file.