Revert "Deduplicate partial and full GMessage validation logic (#1010)"

[Kubuxu]

This reverts commit 54abe92.

We've observed an anomaly in metrics when running this code.
Reverting it temporarily to prevent it from being included in a release until the root cause is identified.

[Copilot]

Pull Request Overview

This PR reverts commit 54abe92 that deduplicated partial and full GMessage validation logic in order to address anomalies observed in metrics. The changes restore separate validation implementations and associated types across the codebase.

• Restores the standalone partial validator in pmsg/partial_validator.go.
• Reverts type and pointer changes from gpbft.PartialGMessage to pmsg.PartialGMessage in multiple files.
• Reinstates the original validator and participant implementations with separate handling for full and partial messages.

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.

File	Description
pmsg/partial_validator.go	Adds back the dedicated partial validator implementation and reintroduces its comments.
pmsg/partial_msg.go	Reverts type changes and pointer usage for partial messages, ensuring consistency.
gpbft/validator.go	Reverts changes in validation logic and error/wrapping messages to restore original behavior.
(Other files)	Update references from gpbft.PartialGMessage to pmsg.PartialGMessage across the project.

Comments suppressed due to low confidence (3)

pmsg/partial_validator.go:33

• [nitpick] Consider expanding this TODO comment with a reference to a tracked issue or an outline of the future refactoring plan so that the technical debt is clearly documented for future improvements.

// TODO: Reduce duplicate code between this and the full validator. Doing this ...

pmsg/partial_msg.go:139

• [nitpick] Verify that the conversion to using pointers for PartialGMessage in the LRU cache and associated helper functions is fully consistent, ensuring no nil dereference issues occur during concurrent processing.

inferJustificationVoteValue(pgmsg.PartialGMessage)

gpbft/validator.go:90

• [nitpick] Double-check that the revised error wrapping and logging messages maintain our standard format across all validators, so that future debugging and metric attribution remain consistent.

if cacheMessage { if _, err := v.cache.Add(msg.Vote.Instance, messageCacheNamespace, buf.Bytes()); err != nil {

[Kubuxu]

After trawling through the logs, it seems like input to signature validation is wrong somewhere in the new code.
I don't think there is a need to revert all of it right now as it seems it fails closed. We can fix it and then retract the release.