Fix bug in F3 stop and use start/stop in catchup tests#1029
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
==========================================
- Coverage 65.58% 65.27% -0.31%
==========================================
Files 80 80
Lines 9703 9703
==========================================
- Hits 6364 6334 -30
- Misses 2847 2868 +21
- Partials 492 501 +9
🚀 New features to boost your workflow:
|
masih
force-pushed
the
masih/test-flaky-pause-resume
branch
2 times, most recently
from
150702e to
865ae86
Compare
masih
changed the title
TestF3PauseResumeCatchup being flakyThere was a problem hiding this comment.
Pull Request Overview
This PR introduces an additional wait period in the tests to ensure nodes have caught up with the certification chain before proceeding, reducing flakage on CI.
- Added a require.Eventually check to verify that node 1 catches up with the certificate chain before proceeding.
- Added a similar check for node 2, although there appears to be an issue with fetching the correct node’s certificate.
masih
force-pushed
the
masih/test-flaky-pause-resume
branch
2 times, most recently
from
b30b333 to
1b6f9d5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Fix a bug where F3.Stop was never calling `stopInternal` which actually resets the state and stops the internal components. Remove the testing API exposed for pause resume in favor of stop start. Because, now that manifest is final, there's no pause/resume and the scenario that was being tested is irrelevant. Instead, stop the nodes completely then start them back up to assert that they do catch up. The flaky test was repeated for 10 minutes on CI without failing. Fixes: #1025
masih
force-pushed
the
masih/test-flaky-pause-resume
branch
from
2afa056 to
bcc04f9
Compare
masih
changed the title
Kubuxu
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug where F3.Stop was never calling
stopInternalwhich actually resets the state and stops the internal components.Remove the testing API exposed for pause resume in favor of stop start. Because, now that manifest is final, there's no pause/resume and the scenario that was being tested is irrelevant. Instead, stop the nodes completely then start them back up to assert that they do catch up.
The flaky test was repeated for 10 minutes on CI without failing.
Fixes: #1025