feat: add deltaBackOffMax to the F3 manifest#1062
Open
hanabi1224 wants to merge 4 commits intofilecoin-project:mainfrom
Open
feat: add deltaBackOffMax to the F3 manifest#1062hanabi1224 wants to merge 4 commits intofilecoin-project:mainfrom
hanabi1224 wants to merge 4 commits intofilecoin-project:mainfrom
Conversation
Member
|
@hanabi1224 : is there any reason this should be a draft rather than "ready for review"? |
Contributor
Author
|
@BigLep I have not updated unit tests to cover the feature |
Member
|
I recommended this PR before understanding the risks of the change. We should hash out in #1056 whether this is safe enough to do. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1056
Hey @BigLep @Kubuxu this draft PR implements
deltaBackOffMaxas described in #1056 Please take a look and let me know if anything is missing or if I have misunderstood anything. Another FIP PR is on its way.