refactor(pmsg): consolidate CompleteMessage short-circuit predicate#1076
Merged
Conversation
Introduce a PartialGMessage.HasChainValue helper that reports whether a partial message carries a chain value to resolve via chainexchange, and use it in CompleteMessage in place of the inline VoteValueKey.IsZero check. Add basic table-driven coverage for the short-circuit paths. Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
rjan90
approved these changes
Apr 29, 2026
|
Fuzz test failed on commit 2a2d0f5. To troubleshoot locally, download the seed corpus using GitHub CLI by running: gh run download 25107489172 -n testdataAlternatively, download directly from here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1076 +/- ##
==========================================
+ Coverage 65.66% 65.76% +0.09%
==========================================
Files 81 81
Lines 8001 8003 +2
==========================================
+ Hits 5254 5263 +9
+ Misses 2217 2213 -4
+ Partials 530 527 -3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a PartialGMessage.HasChainValue helper that reports whether a
partial message carries a chain value to resolve via chainexchange, and
use it in CompleteMessage in place of the inline VoteValueKey.IsZero
check.