Open
Conversation
simlecode
reviewed
Nov 23, 2023
app/node/node.go
Outdated
| func (r *RepoKeeper) Rollback() error { | ||
| ds := r.repo.Datastore() | ||
| if ds == nil { | ||
| fmt.Println("no blockstore found!") |
app/node/node.go
Outdated
|
|
||
| rb, ok := ds.(splitstore.Controller) | ||
| if !ok { | ||
| fmt.Println("split store was disabled") |
Collaborator
There was a problem hiding this comment.
!ok，rb 是 nil，后续使用 rb 会 panic 吧
| } | ||
|
|
||
| func (v *syncVisitor) Stop() { | ||
| v.mutex.Lock() |
Collaborator
Author
There was a problem hiding this comment.
可以动态地决定什么时候停止遍历, 暂时用不到, 已经移除
SplitstoreSize SplitstoreCount
LinZexiao
force-pushed
the
feat/impl-splistore
branch
from
5c7e98a to
2e41814
Compare
LinZexiao
force-pushed
the
feat/impl-splistore
branch
from
9623d93 to
86bf950
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6231 +/- ##
========================================
Coverage 25% 26%
========================================
Files 631 638 +7
Lines 77885 78910 +1025
========================================
+ Hits 20233 20837 +604
- Misses 54985 55348 +363
- Partials 2667 2725 +58 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
关联的Issues (Related Issues)
close #5182
改动 (Proposed Changes)
附注 (Additional Info)
自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that: