Skip to content

Update types.ts#8

Open
podlesny-j wants to merge 1 commit intofiliphric:mainfrom
podlesny-j:patch-1
Open

Update types.ts#8
podlesny-j wants to merge 1 commit intofiliphric:mainfrom
podlesny-j:patch-1

Conversation

@podlesny-j
Copy link
Copy Markdown

typescript check in our repo throws error:

node_modules/cypress-plugin-xhr-toggle/dist/types.d.ts(37,13): error TS2717: Subsequent property declarations must have the same type.  Property 'env' must be of type 'Partial<PluginEnvOptions> | undefined', but here has type 'PluginEnvOptions | undefined'.

I believe this might fix it...?

typescript check in our repo throws error:
```
node_modules/cypress-plugin-xhr-toggle/dist/types.d.ts(37,13): error TS2717: Subsequent property declarations must have the same type.  Property 'env' must be of type 'Partial<PluginEnvOptions> | undefined', but here has type 'PluginEnvOptions | undefined'.
```

I believe this should fix it...?
@podlesny-j
Copy link
Copy Markdown
Author

podlesny-j commented Apr 5, 2023

But to be honest I'm still pretty lost in TS.
But if you'll find time to take a look at this I'll gladly help if I can...

I have a feeling this could also be a cool content for one of your streaming sessions...? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant