Add setup status overview screen - #41
Conversation
|
Decision: changes requested Summary of the change:
Acceptance criteria check:
Main review finding:
CI status summary:
Risks not covered by CI:
Requested changes:
I created follow-up Kanban task |
|
Addressed the Fio readiness review feedback in commit 7402b1e.\n\nSummary:\n- Setup Status now checks non-deleted Fio tokens for the current plugin.\n- Fio readiness is complete only when bank payments are inactive, or when the Fio plugin is active and has at least one usable token.\n- Added helper coverage for active plugin without tokens and inactive bank payments.\n\nVerification:\n- bun test src/features/settings/readiness/readiness-utils.test.ts\n- bun run check:lint\n- bun run check:ts\n- bun run build\n- bun run check:tests (fails in unrelated runtime/polyfill-dependent tests: Promise.try and AsyncDisposableStack are unavailable in the current test runtime; readiness tests pass). |
JanetByte
left a comment
There was a problem hiding this comment.
Decision: approved
Summary of the change:
- Follow-up commit 7402b1e makes the Setup Status Fio item require a usable token for the current Fio plugin when bank payments are active.
- The readiness screen now queries non-deleted tokens for the selected Fio plugin and passes token presence into the pure readiness helper.
- Helper tests cover active plugin without tokens and inactive bank payments.
Acceptance criteria check:
- Original setup/status overview goal remains satisfied: the screen is reachable from Settings and presents a simple localized checklist with status icons, completed/not-completed state, and fix links for incomplete items.
- Prior blocking feedback is satisfied: Fio readiness is complete only when bank payments are inactive, or when the current plugin is active and has at least one non-deleted token.
- The token query is read-only and scoped to the current plugin id; the placeholder id path keeps hook usage unconditional when no plugin exists.
- Tests were updated for the no-token and no-bank-payment edge cases.
Main review findings:
- No blocking findings in the follow-up. The added token predicate matches the sync query’s usable-token semantics (
token IS NOT NULLandisDeleted IS NULL) and the helper logic keeps non-bank setups from being blocked on Fio.
CI status summary:
- GitHub
Bun Checkpassed on head commit 7402b1e. - GitHub
Deploypassed on head commit 7402b1e. - I did not repeat automated CI locally.
Risks not covered by CI:
- Readiness remains a UX-level approximation of live setup state; future changes to Fio sync prerequisites should keep this checklist in sync with the background sync query.
Requested changes:
- None.
Summary
Fixes #32
Verification
Known validation issue