Remove deprecated name and customConfig from AppD specification (#1937) - #1944
Merged
kriswest merged 3 commits intoJul 6, 2026
Merged
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…licDetails (finos#1937) Remove 'name' property from filterPublicDetails method.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1944 +/- ##
==========================================
- Coverage 95.32% 95.32% -0.01%
==========================================
Files 85 85
Lines 6691 6690 -1
Branches 895 866 -29
==========================================
- Hits 6378 6377 -1
Misses 313 313 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Failing
These are baseline repo findings from recently-added semgrep rules, not anything introduced here. This PR only removes the deprecated Suggest addressing the semgrep findings repo-wide in a separate PR (or updating the semgrep baseline) so this change isn't blocked by them. Happy to open that follow-up if useful. |
kriswest
added a commit
that referenced
this pull request
Jul 8, 2026
* chore(ci): harden workflows, pin actions to SHAs, add min-release-age - Upgrade GitHub Actions to latest majors (checkout v7, setup-node v6, codecov v7, upload-artifact v7, download-artifact v8) and pin all references to immutable commit SHAs. - Add StepSecurity harden-runner (v2.19.4) to every workflow job. - Add min-release-age = 7 to .npmrc to block newly published packages. - Add dependabot.yml with cooldown periods and grouped updates. * Update CHANGELOG.md * test(conformance): add optionalFeatures coverage from getInfo() (Refs #1776) (#1888) * feat(conformance): add basicGI2 test for ImplementationMetadata.optionalFeatures (#1776) Adds basicGI2, a conformance test that asserts fdc3.getInfo() returns a valid optionalFeatures object containing booleans for OriginatingAppMetadata, UserChannelMembershipAPIs, and DesktopAgentBridging. Validates shape only, not specific values, so vendor differences in supported features do not cause failures. Refs #1776 * Update testSuite.ts * fix(conformance): cast key to keyof optionalFeatures (TS7053) Adds fdc3BasicGI2 to the basic conformance suite for optionalFeatures coverage from getInfo(). Refs #1776 * test(conformance): drop OriginatingAppMetadata from requiredKeys (3.0) Removed 'OriginatingAppMetadata' from requiredKeys in fdc3 basic tests. * Remove deprecated `name` and `customConfig` from AppD specification (#1937) (#1944) * Remove deprecated name and customConfig from AppD spec (#1937) * Copy updated AppD schema to next (#1937) * Remove reference to deprecated name property in OpenHandler.filterPublicDetails (#1937) Remove 'name' property from filterPublicDetails method. * chore: switch SAST from semgrep to CodeQL and update Node workflows t… (#1868) * chore: switch SAST from semgrep to CodeQL and update Node workflows to v24 - Replace semgrep workflow with CodeQL static analysis (github/codeql-action) to align with OpenSSF Scorecard recognition requirement (issue #1827) - Update CI workflows from Node 20 (EOL) to Node 24 (current LTS): - coverage.yml: Node 20.x to 24.x - release.yml: Node 20 to 24 (all three jobs) - cve-scanning.yml: simplify to single Node 24 (removes matrix) - Add Node engine constraint (>=22) to root package.json per maintainer guidance indicating support floor and future Node 25 capability (issue #1826) Closes #1827 #1826 * fix: restore clean release workflow after rebase * chore(ci): harden and update the actions in the codeql workflow --------- Co-authored-by: ninjabot92 <76234287+ninjabot92@users.noreply.github.com> Co-authored-by: mayank singh <mayankchaudhary.bte05@gmail.com>
Roaders
pushed a commit
that referenced
this pull request
Jul 10, 2026
* chore(ci): harden workflows, pin actions to SHAs, add min-release-age - Upgrade GitHub Actions to latest majors (checkout v7, setup-node v6, codecov v7, upload-artifact v7, download-artifact v8) and pin all references to immutable commit SHAs. - Add StepSecurity harden-runner (v2.19.4) to every workflow job. - Add min-release-age = 7 to .npmrc to block newly published packages. - Add dependabot.yml with cooldown periods and grouped updates. * Update CHANGELOG.md * test(conformance): add optionalFeatures coverage from getInfo() (Refs #1776) (#1888) * feat(conformance): add basicGI2 test for ImplementationMetadata.optionalFeatures (#1776) Adds basicGI2, a conformance test that asserts fdc3.getInfo() returns a valid optionalFeatures object containing booleans for OriginatingAppMetadata, UserChannelMembershipAPIs, and DesktopAgentBridging. Validates shape only, not specific values, so vendor differences in supported features do not cause failures. Refs #1776 * Update testSuite.ts * fix(conformance): cast key to keyof optionalFeatures (TS7053) Adds fdc3BasicGI2 to the basic conformance suite for optionalFeatures coverage from getInfo(). Refs #1776 * test(conformance): drop OriginatingAppMetadata from requiredKeys (3.0) Removed 'OriginatingAppMetadata' from requiredKeys in fdc3 basic tests. * Remove deprecated `name` and `customConfig` from AppD specification (#1937) (#1944) * Remove deprecated name and customConfig from AppD spec (#1937) * Copy updated AppD schema to next (#1937) * Remove reference to deprecated name property in OpenHandler.filterPublicDetails (#1937) Remove 'name' property from filterPublicDetails method. * chore: switch SAST from semgrep to CodeQL and update Node workflows t… (#1868) * chore: switch SAST from semgrep to CodeQL and update Node workflows to v24 - Replace semgrep workflow with CodeQL static analysis (github/codeql-action) to align with OpenSSF Scorecard recognition requirement (issue #1827) - Update CI workflows from Node 20 (EOL) to Node 24 (current LTS): - coverage.yml: Node 20.x to 24.x - release.yml: Node 20 to 24 (all three jobs) - cve-scanning.yml: simplify to single Node 24 (removes matrix) - Add Node engine constraint (>=22) to root package.json per maintainer guidance indicating support floor and future Node 25 capability (issue #1826) Closes #1827 #1826 * fix: restore clean release workflow after rebase * chore(ci): harden and update the actions in the codeql workflow --------- Co-authored-by: ninjabot92 <76234287+ninjabot92@users.noreply.github.com> Co-authored-by: mayank singh <mayankchaudhary.bte05@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Removes the
nameandcustomConfigproperties from the App DirectoryApplicationrecord. Both were deprecated back in FDC3 2.0, so they should no longer appear in the FDC3 3.0 AppD specification.Changes:
nameandcustomConfigfrom theBaseApplicationschema inpackages/fdc3-standard/src/app-directory/specification/appd.schema.json.nameproperty from the AppD example payloads (myApplication.json,fdc3-workbench.json).static/schemas/next/appd.schema.jsonvianpm run copy-appd.### Removedentry toCHANGELOG.md.Scope notes (intentionally left untouched to keep this scoped to the issue):
ApplicationV1/IntentV1schemas.Intent.customConfig, which is a separate, differently-motivated deprecation.NameValuePairschema, which is still referenced by the above.Happy to expand scope in a follow-up if maintainers prefer.
Related Issue
Resolves #1937.
Complements #1928 (which removed deprecated Desktop Agent / Channel API functions); this PR handles the AppD spec side. Kept independent of the ongoing AppD work in #1926 so it can merge on its own.
Contributor License Agreement (CLA)
A CLA is required to contribute to this project - please refer to the CONTRIBUTING.md file for details. By raising this Pull Request I confirm I am covered by an applicable CLA.