Run automated conformance suite in CI - #2048
Conversation
|
|
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/easycla |
…rmance-ci # Conflicts: # CHANGELOG.md
…rmance-ci # Conflicts: # package-lock.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2048 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 73 73
Lines 4196 4196
Branches 581 670 +89
=======================================
Hits 3991 3991
Misses 205 205 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This looks promising as an initial way to get these tests running as part of the CI process but we must be sure that the build will fail if the tests fail. As the tests timeout at the moment but this build is still fine I am not sure this is the case. |
Signed-off-by: russlan23 <rrusslanjr@gmail.com>
|
Addressed in 335fc22. I added an explicit result gate that throws unless the conformance run reports passed, has zero failures, executes at least one test, and completes every reported test. I also added negative coverage for failed or timed-out and incomplete runs. Local verification: npm run test:ci --workspace fdc3-conformance — 4 passed in 5.9m. A conformance failure, incomplete run, or the existing outer Playwright timeout now returns a non-zero exit from the command used directly by the CI job. |
|
Addressed in 335fc22. I added an explicit result gate that throws unless the conformance run reports , has zero failures, executes at least one test, and completes every reported test. I also added negative coverage for failed/timed-out and incomplete runs.\n\nLocal verification:
Running 4 tests using 1 worker ✓ 1 e2e/conformance.spec.ts:9:1 › runs all automated conformance tests against the reference Desktop Agent (5.8m) Slow test file: e2e/conformance.spec.ts (5.8m) |
Signed-off-by: russlan23 <rrusslanjr@gmail.com>
|
Rebased this branch onto current The full gate now executes and reports three failures on current
The three result-gate unit tests still pass. I have not mixed changes to #1942 behavior into this CI PR; I will keep those fixes separate if maintainers want a follow-up. |
Describe your change
Adds a Playwright contribution check for the FDC3 conformance framework. The check starts the conformance app and the FDC3 for Web reference Desktop Agent, launches the runner inside the Desktop Agent, selects the complete non-manual pack, and fails with the underlying conformance failure messages when any test fails.
The browser runner now exposes machine-readable status and totals after the Mocha run. While exercising the pack, the check also exposed three setup and cleanup problems in the recently added destructured-method tests; this change supplies the required
getAppMetadataargument, waits for freshly opened mock apps to initialize, awaits the close broadcast, and uses the existing mock-processing timeout.Manual intent-resolver and channel-selector tests remain outside this automated check.
Validation performed:
fdc3.destructuredMethodspack: 8 passed, 0 failednpm run testnpm run lint(passes with existing workbench warnings)npm run build --workspace fdc3-conformancenpm run test:ci --workspace fdc3-conformance -- --listRelated Issue
Resolves #2045.
Contributor License Agreement
Review Checklist
CHANGELOG.mdentry is included.