Add zoned date time generic impl - #28
Merged
dschwartznyc merged 7 commits intoAug 25, 2025
Merged
Conversation
dschwartznyc
pushed a commit
that referenced
this pull request
Aug 8, 2025
…/priyanka-amarnani/rune-python-generator into add-zoned-date-time-generic-impl
# Conflicts: # test/python_unit_tests/semantics/test_to_zoned_date_time.py
| import pytest | ||
|
|
||
| from rosetta_dsl.test.semantic.zoned_date_time_operator.ZonedDateTimeOperatorTest import ZonedDateTimeOperatorTest | ||
| from rosetta_dsl.test.semantic.toZonedDateTimeOp.TestToZonedDateTimeOp import TestToZonedDateTimeOp |
Contributor
There was a problem hiding this comment.
believe this import and the class usage need to be aligned to the naming of the class created: ZonedDateTimeOperatorTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the implementation of the issue , an opportunity to generalize the to-zoned-date-time operator was identified. The goal of this generalization is to allow a wider range of input strings to be parsed into a zoned date-time object. This new implementation works with a runtime function (
rune_zoned_date_time) and includes tests for the variety of string formats that can be used as an input to create a zoned-datetime object. To work with time zones, the Python library used to interpret them required thetzdata>=2023.3 dependency.