Add viewport typeahead to DefaultRpcHandler and use as default setting - #1625
Merged
Merged
Conversation
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
tanjjj
marked this pull request as draft
July 22, 2025 17:12
tanjjj
marked this pull request as ready for review
July 23, 2025 11:28
tanjjj
force-pushed
the
use-viewport-typeahead-in-SimulMain
branch
from
July 23, 2025 13:32
56d6991 to
e25220c
Compare
heswell
requested changes
Jul 23, 2025
heswell
left a comment
heswell
left a comment
Contributor
There was a problem hiding this comment.
testing from UI. ALmost working but results not being returned to UI
stonesmi
reviewed
Jul 24, 2025
Contributor
|
The current typeahead solution as implemented in the DistinctValuesGetter returns the first 10 distinct values matching our pattern. |
heswell
approved these changes
Jul 24, 2025
stonesmi
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since typeahead is already enabled for all tables in demo code, switch to use viewport version and set it as default
Closes #1434