Add sessionType to createSessionDataSource and fix csvupload error rows preview - #2345
Merged
heswell merged 2 commits intoAug 27, 2026
Conversation
anandBalachandar
commented
Aug 26, 2026
anandBalachandar
commented
Contributor
- Add SessionType ("edit"|"import"|"export") type; thread sessionType through EditSession.begin → createSessionDataSource → createSessionTable RPC
- Import sessions get vuuRowNum column in session table schema at creation time
- Error rows sent to addRow as {vuuRowNum, vuuMsg} only; key falls back to vuuRowNum
- Fix: filterPredicate had no "!=" case — default returned () => true, passing all rows
- Fix: ArrayDataSource.getFilterPredicate uses dataMap positions to prevent wrong column evaluation after processNewColumns rebuilds #columnMap on restricted subscribe
- Add CsvUploadWithErrorsOnlyPreview showcase example
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
… error row preview
- Add SessionType ("edit"|"import"|"export") type; thread sessionType through
EditSession.begin → createSessionDataSource → createSessionTable RPC
- Import sessions get vuuRowNum column in session table schema at creation time
- Error rows sent to addRow as {vuuRowNum, vuuMsg} only; key falls back to vuuRowNum
- Fix: filterPredicate had no "!=" case — default returned () => true, passing all rows
- Fix: ArrayDataSource.getFilterPredicate uses dataMap positions to prevent wrong
column evaluation after processNewColumns rebuilds #columnMap on restricted subscribe
- Add CsvUploadWithErrorsOnlyPreview showcase example
Listing file errors in the upload component Setting default MaxRows to 10000
anandBalachandar
force-pushed
the
task/add-sessiontype-to-createsessiondatasource
branch
from
August 26, 2026 15:20
999bc7b to
4121381
Compare
anandBalachandar
marked this pull request as ready for review
August 26, 2026 15:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.