Skip to content

Show file errors in drop zone and add rowDefaults support - #2348

Merged
heswell merged 3 commits into
finos:mainfrom
anandBalachandar:task/add-rowdefaults-map-editsession
Aug 28, 2026
Merged

Show file errors in drop zone and add rowDefaults support#2348
heswell merged 3 commits into
finos:mainfrom
anandBalachandar:task/add-rowdefaults-map-editsession

Conversation

@anandBalachandar

@anandBalachandar anandBalachandar commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

CSV upload error display (CsvUpload.tsx)

  • File-level validation errors (missing key column, unknown columns, max rows exceeded) are now listed in the drop zone under "Your file contains errors"
  • CSS classes vuuCsvUpload-errorList and vuuCsvUpload-errorItem added for consumer styling

Refactor

  • MAX_ROWS_IN_CSV moved from csv-schema-validation.ts to csv-constants.ts and exported

Row defaults (EditSession, useCsvUpload, useEditableTable)

  • EditSession accepts an optional rowDefaults
  • rowDefaults prop added to CsvUploadProps / CsvUploadHookProps and forwarded to EditSession
  • rowDefaults prop added to EditableTableHookProps
  • PW test added

@netlify

netlify Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for papaya-valkyrie-395400 canceled.

Name Link
🔨 Latest commit cbdc189
🔍 Latest deploy log https://app.netlify.com/projects/papaya-valkyrie-395400/deploys/6a901fe712674a0008a35e48

heswell
heswell reviewed Aug 27, 2026
View reviewed changes
Comment thread vuu-ui/packages/vuu-data-editing/src/EditSession.tsx Outdated
heswell
heswell reviewed Aug 27, 2026
View reviewed changes
Comment thread vuu-ui/packages/vuu-data-editing/src/EditSession.tsx
heswell
heswell reviewed Aug 27, 2026
View reviewed changes
Comment thread vuu-ui/packages/vuu-data-editing/src/useEditableTable.ts Outdated
heswell
heswell reviewed Aug 27, 2026
View reviewed changes
Comment thread vuu-ui/packages/vuu-data-editing/src/EditSession.tsx Outdated
@anandBalachandar
anandBalachandar force-pushed the task/add-rowdefaults-map-editsession branch from 4baf310 to 36f1ccf Compare August 27, 2026 10:24
@anandBalachandar
anandBalachandar force-pushed the task/add-rowdefaults-map-editsession branch from d265423 to 830e422 Compare August 27, 2026 11:30
@anandBalachandar
anandBalachandar marked this pull request as ready for review August 27, 2026 12:32
@heswell
heswell merged commit 78651ea into finos:main Aug 28, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heswell heswell heswell left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anandBalachandar @heswell