forked from FEniCS/fiat
-
Notifications
You must be signed in to change notification settings - Fork 7
C2 (macro)elements #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
C2 (macro)elements #212
Changes from 20 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
b7bf542
Wu-Xu H3 non-conforming triangle
pbrubeck e7e8b51
fix zany map
pbrubeck 7cb2607
register the element
pbrubeck 4f41966
cleanup
pbrubeck 7d63ce1
cleanup
pbrubeck d396550
Fix conditioning
pbrubeck cd5879f
H3 Sobolev space
pbrubeck a5c4cc3
Refactor functionals
pbrubeck 903e8de
use FacetQuadratureRule(..., avg=True)
pbrubeck 0f2d2d0
docstring
pbrubeck e248b3f
fix Wu-Xu names
pbrubeck 631b680
Merge branch 'pbrubeck/wuxu' into pbrubeck/deriv-moment
pbrubeck 0d524a9
DualSet: BLAS3 optimization for IntegralMomentOfDerivative
pbrubeck ec23f0c
Double Alfeld C2 macroelement
pbrubeck 71661b2
avg by default
pbrubeck d62f91d
_jet_transform
pbrubeck b6f1919
Merge branch 'pbrubeck/deriv-to-riesz' into pbrubeck/double-alfeld
pbrubeck ea46922
tidy
pbrubeck f28b62c
cleanup
pbrubeck cb9f4ff
register element
pbrubeck 14e0c9b
more generic C2DualSet
pbrubeck f7d1b6a
Bramble-Zlamal C2 element
pbrubeck 78c6ecd
Apply suggestions from code review
pbrubeck 8d1a14d
flake8
pbrubeck 7c970e5
Fix abbreviation
pbrubeck 00b1dfd
Merge branch 'main' into pbrubeck/double-alfeld
pbrubeck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| # Copyright (C) 2026 Pablo D. Brubeck | ||
| # | ||
| # This file is part of FIAT (https://www.fenicsproject.org) | ||
| # | ||
| # SPDX-License-Identifier: LGPL-3.0-or-later | ||
| # | ||
| # Written by Pablo D. Brubeck (brubeck@protonmail.com), 2026 | ||
|
|
||
| from FIAT.functional import (PointEvaluation, PointDerivative, | ||
| IntegralMoment, IntegralMomentOfDerivative) | ||
| from FIAT import finite_element, dual_set, macro, polynomial_set | ||
| from FIAT.polynomial_set import mis | ||
| from FIAT.check_format_variant import parse_quadrature_scheme | ||
| from FIAT.reference_element import TRIANGLE, ufc_simplex | ||
| from FIAT.quadrature import FacetQuadratureRule | ||
| from FIAT.jacobi import eval_jacobi_batch, eval_jacobi_deriv_batch | ||
|
|
||
|
|
||
| class DoubleAlfeldDualSet(dual_set.DualSet): | ||
| def __init__(self, ref_complex, degree, reduced=False, quad_scheme=None): | ||
| if degree < 5: | ||
| raise ValueError("Double Alfeld only defined for degree >= 5") | ||
| ref_el = ref_complex.get_parent() | ||
| if ref_el.get_shape() != TRIANGLE: | ||
| raise ValueError("Double Alfeld only defined on triangles") | ||
| top = ref_el.get_topology() | ||
| verts = ref_el.get_vertices() | ||
| sd = ref_el.get_spatial_dimension() | ||
| entity_ids = {dim: {entity: [] for entity in sorted(top[dim])} for dim in sorted(top)} | ||
|
|
||
| # get second order jet at each vertex | ||
| order = 2 | ||
| nodes = [] | ||
| for v in sorted(top[0]): | ||
| pt = verts[v] | ||
| cur = len(nodes) | ||
| nodes.append(PointEvaluation(ref_el, pt)) | ||
| nodes.extend(PointDerivative(ref_el, pt, alpha) for i in range(1, order+1) for alpha in mis(sd, i)) | ||
| entity_ids[0][v].extend(range(cur, len(nodes))) | ||
|
|
||
| k = degree-1 if reduced else degree-4 | ||
| facet = ufc_simplex(1) | ||
| Q_ref = parse_quadrature_scheme(facet, degree-2+k, quad_scheme) | ||
| x = facet.compute_barycentric_coordinates(Q_ref.get_points()) | ||
| xref = x[:, [1]] - x[:, [0]] | ||
|
|
||
| if reduced: | ||
| raise NotImplementedError | ||
| else: | ||
| phis = eval_jacobi_batch(order, order, k, xref) | ||
| dphis = 2*eval_jacobi_deriv_batch(order, order, k, xref, order=1) | ||
| ddphis = 4*eval_jacobi_deriv_batch(order, order, k, xref, order=2) | ||
| for e in sorted(top[1]): | ||
| Q = FacetQuadratureRule(ref_el, 1, e, Q_ref, avg=True) | ||
| n = ref_el.compute_normal(e) | ||
| cur = len(nodes) | ||
| nodes.extend(IntegralMoment(ref_el, Q, ddphi) for ddphi in ddphis[2:]) | ||
| nodes.extend(IntegralMomentOfDerivative(ref_el, Q, dphi, n) for dphi in dphis[1:]) | ||
| nodes.extend(IntegralMomentOfDerivative(ref_el, Q, phi, n, n) for phi in phis) | ||
| entity_ids[1][e].extend(range(cur, len(nodes))) | ||
|
|
||
| q = degree - 6 | ||
| if q >= 0: | ||
| Q = parse_quadrature_scheme(ref_complex, degree + q, quad_scheme) | ||
| Pq = polynomial_set.ONPolynomialSet(ref_el, q, scale=1) | ||
| phis = Pq.tabulate(Q.get_points())[(0,) * sd] | ||
| phis *= 1/ref_el.volume() | ||
| cur = len(nodes) | ||
| nodes.extend(IntegralMoment(ref_el, Q, phi) for phi in phis) | ||
| entity_ids[sd][0].extend(range(cur, len(nodes))) | ||
|
|
||
| super().__init__(nodes, ref_el, entity_ids) | ||
|
|
||
|
|
||
| class DoubleAlfeld(finite_element.CiarletElement): | ||
| """The double Alfeld C^2 macroelement on a double barycentric split. | ||
| See Section 7.5 of Lai & Schumacher for the quintic C2 spline. | ||
| """ | ||
| def __init__(self, ref_el, degree=5, reduced=False, quad_scheme=None): | ||
| # Construct the quintic C2 spline on the double Alfeld split | ||
| ref_complex = macro.AlfeldSplit(macro.AlfeldSplit(ref_el)) | ||
| dual = DoubleAlfeldDualSet(ref_complex, degree, reduced=reduced, quad_scheme=quad_scheme) | ||
|
|
||
| # C3 on major split facets, C2 elsewhere | ||
| order = {} | ||
| order[1] = dict.fromkeys(ref_complex.get_interior_facets(1), 2) | ||
| order[1].update(dict.fromkeys(range(3, 6), degree-2)) | ||
| # C4 at minor split barycenters, C3 at major split barycenter | ||
| order[0] = dict.fromkeys(ref_complex.get_interior_facets(0), degree-1) | ||
| order[0][3] = degree-2 | ||
|
|
||
| poly_set = macro.CkPolynomialSet(ref_complex, degree, order=order, variant="bubble") | ||
| formdegree = 0 | ||
| super().__init__(poly_set, dual, degree, formdegree=formdegree) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.