Skip to content

QuadratureElement: fix dimension check #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbrubeck merged 3 commits into from
Jan 30, 2026
Merged

QuadratureElement: fix dimension check #215

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83073d1
QuadratureElement: fix dimension check
pbrubeck Jan 30, 2026
ab53cc3
create_runtime_quadrature_element
pbrubeck Jan 30, 2026
cac7da1
revert
pbrubeck Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions finat/quadrature_element.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,13 @@ def basis_evaluation(self, order, ps, entity=None, coordinate_mapping=None):
:param ps: the point set object.
:param entity: the cell entity on which to tabulate.
'''
rule_dim = self._rule.point_set.dimension
if entity is None:
entity = (rule_dim, 0)
entity = (self.cell.get_dimension(), 0)
entity_dim, entity_id = entity
if isinstance(entity_dim, tuple):
entity_dim = sum(entity_dim)

rule_dim = self._rule.point_set.dimension
if entity_dim != rule_dim:
raise ValueError(f"Cannot tabulate QuadratureElement of dimension {rule_dim}"
f" on subentities of dimension {entity_dim}.")
Expand Down