Skip to content

Add quadratures from gen-quad#89

Open
pbrubeck wants to merge 4 commits into
mainfrom
pbrubeck/gen-quad
Open

Add quadratures from gen-quad#89
pbrubeck wants to merge 4 commits into
mainfrom
pbrubeck/gen-quad

Conversation

@pbrubeck

@pbrubeck pbrubeck commented Oct 16, 2024

Copy link
Copy Markdown

Degree 16 - 22 tetrahedral quadrature rules computed with https://github.com/arkslobodkins/gen-quad

@pbrubeck

Copy link
Copy Markdown
Author

@wence- how should we give credit to the author?

Comment thread FIAT/gen_quad_data.py
@@ -0,0 +1,5823 @@
# GENERATED, DO NOT EDIT
# Slobodkins-Tausch quadratures

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest linking to the code repo (with a commit hash), so that someone else knows what was run to generate this.

Comment on lines +336 to +337
def gen_quad_simplex(dim):
ref_el = symmetric_simplex(dim)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the citation here as well?

@wence-

wence- commented Oct 16, 2024

Copy link
Copy Markdown

@wence- how should we give credit to the author?

We don't currently hook the Citations mechanism up in FIAT. Maybe we should. Then we could register all the citations for quadrature rules and it would be automatic for -citations.

@rckirby rckirby left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still of interest? There were discussions of citations. FIAT never picked up the petsc citation engine, but FInAT uses it and then got stuck inside of FIAT. Maybe it's time to pick that back up.

@pbrubeck

pbrubeck commented Aug 8, 2025

Copy link
Copy Markdown
Author

We cannot merge this yet as we need to be able to generate the tables automatically.

@connorjward

Copy link
Copy Markdown

We should move the citations tool to petsctools. Then it could get used here. It would make FIAT depend on petsc4py though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants