Correct cloud conversion code#735
Open
12shughes wants to merge 4 commits into
Open
Conversation
tommbendall
requested changes
May 18, 2026
tommbendall
left a comment
tommbendall
left a comment
Contributor
There was a problem hiding this comment.
Thanks for tackling this @12shughes ! I have left a couple of suggestions but happy for you to disagree
Co-authored-by: Thomas Bendall <14180399+tommbendall@users.noreply.github.com>
Co-authored-by: Thomas Bendall <14180399+tommbendall@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct
SWSaturationAdjustment()to give correct conversion of cloud into water vapour. Comparegamma_v*(q_v-q_sat)toq_crather than comparison withoutgamma_vand multiplication withgamma_voccurring later.