Skip to content

fix: validate reference arguments in api_client instead of failing silently #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuvrajnode wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate reference arguments in api_client instead of failing silently #1319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions tools/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,16 +143,23 @@ def parse_args():
idstr: str | None = args.reference_id
# priority: ref_id > [{text, audio},...]
if idstr is None:
ref_audios = args.reference_audio
ref_texts = args.reference_text
if ref_audios is None:
byte_audios = []
else:
byte_audios = [audio_to_bytes(ref_audio) for ref_audio in ref_audios]
if ref_texts is None:
ref_texts = []
else:
ref_texts = [read_ref_text(ref_text) for ref_text in ref_texts]
ref_audios = args.reference_audio or []
ref_texts = args.reference_text or []

if len(ref_audios) != len(ref_texts):
raise SystemExit(
"--reference_audio and --reference_text must be given the same number "
f"of values, got {len(ref_audios)} audio(s) and {len(ref_texts)} text(s)."
)

byte_audios = []
for ref_audio in ref_audios:
audio_bytes = audio_to_bytes(ref_audio)
if audio_bytes is None:
raise SystemExit(f"Reference audio file not found: {ref_audio}")
byte_audios.append(audio_bytes)

ref_texts = [read_ref_text(ref_text) for ref_text in ref_texts]
else:
byte_audios = []
ref_texts = []
Expand All @@ -161,9 +168,7 @@ def parse_args():
data = {
"text": args.text,
"references": [
ServeReferenceAudio(
audio=ref_audio if ref_audio is not None else b"", text=ref_text
)
ServeReferenceAudio(audio=ref_audio, text=ref_text)
for ref_text, ref_audio in zip(ref_texts, byte_audios)
],
"reference_id": idstr,
Expand Down