move nvidia related code from flagcx core

[yzhang35]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @yzhang35, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refactoring the codebase by extracting NVIDIA-specific tuning configurations from the core module into a newly created flagcx/adaptor/tuner module. This change enhances the modularity of the project, making the core components more generic and easier to manage, while centralizing hardware-specific adaptations. The build system has been updated to seamlessly integrate these new components.

Highlights

• Refactoring NVIDIA-specific Code: NVIDIA-related NCCL environment configurations and their loading logic have been moved out of the flagcx/core module.
• New Tuner Module: A new module, flagcx/adaptor/tuner, has been introduced to house the NVIDIA-specific tuning utilities, improving modularity and separation of concerns.
• Build System Updates: The Makefile has been updated to correctly include the new flagcx/adaptor/tuner directory for headers and to compile the new tuner_util.cc source file.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully refactors NVIDIA-specific tuner configuration out of the core logic into a dedicated flagcx/adaptor/tuner directory. This is a good architectural improvement that enhances modularity. My review includes a few suggestions to improve code readability and adhere to C++ best practices in the newly added files.

[MC952-arch]

LGTM

[mikethegoblin]

LGTM