add tuner config for mccl

[mikethegoblin]

• added tuner config for mccl
• fixed compilation issue caused by undefined reference to vars in auto-tuner component

[gemini-code-assist]

Summary of Changes

Hello @mikethegoblin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the auto-tuner component by integrating configuration options for the MCCL library and addressing a critical compilation issue. It centralizes the management of tuner-related environment variables, allowing the system to dynamically select the appropriate set of tuning parameters based on the underlying adaptor, thereby improving flexibility and build stability.

Highlights

• MCCL Tuner Configuration: Introduced a new configuration file (mccl_tuner.cc) to define environment variables for tuning the MCCL collective communication library, covering aspects like algorithm, protocol, channel counts, and cache behavior.
• Compilation Fix for vars: Resolved a compilation error by refactoring the vars vector definition. This involved renaming the existing vars in nccl_tuner.cc to ncclTunerVars, introducing mcclTunerVars in the new MCCL tuner file, and creating a central tuner.cc to conditionally define the global vars based on the active adaptor (NVIDIA or METAX).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request adds tuner configurations for MCCL and fixes a compilation issue related to an undefined reference in the auto-tuner component. The changes involve creating a new file mccl_tuner.cc, modifying nccl_tuner.cc, tuner.cc, and tuner_util.h to include MCCL tuner variables and ensure proper variable initialization based on the adaptor being used. The review focuses on correctness and maintainability, particularly ensuring that the new MCCL tuner configurations are correctly integrated and that the code remains readable and maintainable.

[MC952-arch]

LGTM

[heavyrain-lzy]

LGTM