Skip to content

[PAL] Add barex transport adaptor #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ymmyys wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[PAL] Add barex transport adaptor #526

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
993783e
p2p: add ACCL (accl::barex) transport for PPU hosts
ymmyys Jul 30, 2026
c347c34
net: add barex adaptor for the collective/C2C path on PPU hosts
ymmyys Jul 30, 2026
ec5a53a
p2p/net: harden ACCL transports after adversarial review
ymmyys Jul 30, 2026
f1aaf19
net/barex: fix CTS reordering corruption on multi-chunk transfers
ymmyys Jul 30, 2026
57396dc
p2p, net/barex: trim added comments to match FlagCX style
ymmyys Jul 31, 2026
f4b4ccb
remove useless #ifdef, add an accl check to flagcxP2pRpcBatchWriteSyn…
leoda1 Aug 4, 2026
687fdad
build: link default dev-api backend on PPU
ymmyys Aug 6, 2026
7e2f3d8
style: drop section banners and narration comments
ymmyys Aug 10, 2026
7db8e8a
test: add USE_PPU platform branch to test/make.inc
ymmyys Aug 10, 2026
0ffdbd5
p2p/accl: chunk MR registration to fit vsolar's 64MB per-MR cap
ymmyys Aug 10, 2026
3be8386
net/barex: erase channelComm entry and free comm on HELLO error paths
ymmyys Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ USE_TSM ?= 0
USE_MPI ?= 0
USE_UCX ?= 0
USE_IBUC ?= 0
USE_ACCL_BAREX ?= 0
USE_ENFLAME ?= 0
USE_SUNRISE ?= 0
USE_PPU ?= 0
Expand Down Expand Up @@ -215,6 +216,20 @@ ifeq ($(USE_IBUC), 1)
NET_ADAPTOR_FLAG += -DUSE_IBUC
endif

# ACCL (accl::barex) transport for PPU + vsolar hosts lacking peer-mem/DMA-BUF.
# Devel package installs under /usr; select at runtime with FLAGCX_P2P_TRANSPORT=accl.
ifeq ($(USE_ACCL_BAREX), 1)
ACCL_BAREX_HOME ?= /usr
ACCL_BAREX_INCLUDE = $(ACCL_BAREX_HOME)/include
ACCL_BAREX_LIB = $(ACCL_BAREX_HOME)/lib
ACCL_BAREX_LINK = -laccl_barex
NET_ADAPTOR_FLAG += -DUSE_ACCL_BAREX -DCMAKE_INCLUDE=1
else
ACCL_BAREX_INCLUDE = .
ACCL_BAREX_LIB = .
ACCL_BAREX_LINK =
endif

ifeq ($(COMPILE_KERNEL), 1)
COMPILE_KERNEL_FLAG = -DCOMPILE_KERNEL
COMPILE_KERNEL_HOST_FLAG = -DCOMPILE_KERNEL_HOST
Expand Down Expand Up @@ -323,7 +338,7 @@ endif
$(LIBDIR)/$(TARGET): $(LIBOBJ) $(DEVOBJS)
@mkdir -p `dirname $@`
@echo "Linking $@"
@$(LINKER) $^ -o $@ -L$(CCL_LIB) -L$(DEVICE_LIB) -L$(HOST_CCL_LIB) -L$(UCX_LIB) -shared -fvisibility=default -Wl,--no-as-needed -Wl,-rpath,$(LIBDIR) -Wl,-rpath,$(CCL_LIB) -Wl,-rpath,$(HOST_CCL_LIB) -Wl,-rpath,$(UCX_LIB) -lpthread -lrt -ldl $(CCL_LINK) $(DEVICE_LINK) $(HOST_CCL_LINK) $(UCX_LINK) -g
@$(LINKER) $^ -o $@ -L$(CCL_LIB) -L$(DEVICE_LIB) -L$(HOST_CCL_LIB) -L$(UCX_LIB) -L$(ACCL_BAREX_LIB) -shared -fvisibility=default -Wl,--no-as-needed -Wl,-rpath,$(LIBDIR) -Wl,-rpath,$(CCL_LIB) -Wl,-rpath,$(HOST_CCL_LIB) -Wl,-rpath,$(UCX_LIB) -Wl,-rpath,$(ACCL_BAREX_LIB) -lpthread -lrt -ldl $(CCL_LINK) $(DEVICE_LINK) $(HOST_CCL_LINK) $(UCX_LINK) $(ACCL_BAREX_LINK) -g

# Copy public headers from flagcx/include/ into the build output tree so they
# sit next to the shared libraries (build/include + build/lib).
Expand All @@ -335,7 +350,7 @@ $(BUILD_INCDIR)/%.h: flagcx/include/%.h
$(OBJDIR)/%.o: %.cc
@mkdir -p `dirname $@`
@echo "Compiling $@"
@$(HOST_COMPILER) $< -o $@ $(foreach dir,$(INCLUDEDIR),-I$(dir)) -I$(CCL_INCLUDE) $(addprefix -I,$(DEVICE_INCLUDE)) -I$(HOST_CCL_INCLUDE) -I$(UCX_INCLUDE) $(ADAPTOR_FLAG) $(HOST_CCL_ADAPTOR_FLAG) $(NET_ADAPTOR_FLAG) $(COMPILE_KERNEL_HOST_FLAG) -c -fPIC -fvisibility=default -Wvla -Wno-unused-function -Wno-sign-compare -Wall -MMD -MP -g
@$(HOST_COMPILER) $< -o $@ $(foreach dir,$(INCLUDEDIR),-I$(dir)) -I$(CCL_INCLUDE) $(addprefix -I,$(DEVICE_INCLUDE)) -I$(HOST_CCL_INCLUDE) -I$(UCX_INCLUDE) -I$(ACCL_BAREX_INCLUDE) $(ADAPTOR_FLAG) $(HOST_CCL_ADAPTOR_FLAG) $(NET_ADAPTOR_FLAG) $(COMPILE_KERNEL_HOST_FLAG) -c -fPIC -fvisibility=default -Wvla -Wno-unused-function -Wno-sign-compare -Wall -MMD -MP -g

ifeq ($(COMPILE_KERNEL), 1)
$(OBJDIR)/kernel_dlink.o: $(DEVOBJ)
Expand Down
8 changes: 8 additions & 0 deletions flagcx/adaptor/adaptor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,10 @@ extern struct flagcxNetAdaptor flagcxNetIbuc;
#ifdef USE_UCX
extern struct flagcxNetAdaptor flagcxNetUcx;
#endif

#ifdef USE_ACCL_BAREX
extern struct flagcxNetAdaptor flagcxNetBarex;
#endif
extern struct flagcxNetAdaptor flagcxNetIbP2p;

// Unified network adaptor entry point
Expand All @@ -189,6 +193,10 @@ struct flagcxNetAdaptor *getUnifiedNetAdaptor(int netType) {
#elif USE_IBUC
// When IBUC is enabled, use IBUC instead of IBRC
return &flagcxNetIbuc;
#elif USE_ACCL_BAREX
// When ACCL barex is enabled (PPU + vsolar hosts), use it instead
// of IBRC; FLAGCX_BAREX_DISABLE=1 falls back to socket at runtime.
return &flagcxNetBarex;
#else
return &flagcxNetIb;
#endif
Expand Down
Loading
Loading