Skip to content

fix(packaging): use system nlohmann-json - #530

Merged
MC952-arch merged 1 commit into
flagos-ai:mainfrom
shiptux:fix/packaging-system-json
Aug 14, 2026
Merged

fix(packaging): use system nlohmann-json#530
MC952-arch merged 1 commit into
flagos-ai:mainfrom
shiptux:fix/packaging-system-json

Conversation

@shiptux

@shiptux shiptux commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make the nlohmann-json include root configurable while preserving the git submodule default for source builds
  • build Debian and RPM packages against /usr/include and declare the matching distro build dependency
  • fix RPM dependency selection: Fedora and RHEL/EPEL use json-devel; openEuler uses nlohmann-json-devel

Verification

  • parsed setup.py with Python AST
  • confirmed a FlagCX make dry-run emits -I/usr/include
  • parsed the RPM spec for Fedora 43, RHEL 9, and openEuler macro sets
  • verified package availability: Fedora 43/Rocky 9 provide json-devel 3.11.3; openEuler 24.03 provides nlohmann-json-devel 3.11.2

@MC952-arch MC952-arch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MC952-arch
MC952-arch merged commit ac4a9f2 into flagos-ai:main Aug 14, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants