Bump torchvision from 0.15.1+metax3.7.2.0 to 0.28.0 - #239
Conversation
Dongxu-H
left a comment
There was a problem hiding this comment.
torchvision 0.28.0 requires PyTorch 2.15+ but the project uses torch versions from 2.7.0 to 2.11.0 across different backends. This creates version incompatibilities:
metax backend: torch==2.8.0 incompatible with torchvision 0.28.0
kunlunxin backend: torch==2.9.0 incompatible with torchvision 0.28.0
enflame/nvidia-cuda128: torch==2.10.0 incompatible with torchvision 0.28.0
nvidia-cuda133/sunrise: torch==2.11.0 incompatible with torchvision 0.28.0
iluvatar: torch==2.7.1 incompatible with torchvision 0.28.0
Each backend should use torchvision version that matches its torch version. For reference: torch 2.8 → torchvision 0.21, torch 2.9 → torchvision 0.22, torch 2.10 → torchvision 0.25, torch 2.11 → torchvision 0.26.
This PR should be closed. Dependabot does not understand vendor-specific torch/torchvision version constraints.
Dongxu-H
left a comment
There was a problem hiding this comment.
torchvision 0.28.0 requires PyTorch 2.15+ but the project uses torch versions from 2.7.0 to 2.11.0 across different backends. This creates version incompatibilities.
metax backend: torch==2.8.0 incompatible with torchvision 0.28.0
kunlunxin backend: torch==2.9.0 incompatible with torchvision 0.28.0
enflame/nvidia-cuda128: torch==2.10.0 incompatible with torchvision 0.28.0
nvidia-cuda133/sunrise: torch==2.11.0 incompatible with torchvision 0.28.0
iluvatar/tsingmicro: torch==2.7.x incompatible with torchvision 0.28.0
Each backend should use torchvision version that matches its torch version. For reference: torch 2.8 → torchvision 0.21, torch 2.9 → torchvision 0.22, torch 2.10 → torchvision 0.25, torch 2.11 → torchvision 0.26.
This PR should be closed. Dependabot does not understand vendor-specific torch/torchvision version constraints.
3b783b7 to
cd3f314
Compare
Dongxu-H
left a comment
There was a problem hiding this comment.
CI code-style check failed. Please check the workflow logs for details. Otherwise the torchvision version bump across multiple backends looks reasonable.
Dongxu-H
left a comment
There was a problem hiding this comment.
CI code-style check failed. Updating torchvision versions across all backends to 0.28.0 will break vendor-specific SDK compatibility. Each backend requires specific torchvision versions to match their vendor torch and SDK versions (e.g., metax needs torchvision==0.15.1+metax3.7.2.0 to match torch==2.8.0+metax3.7.2.0, kunlunxin needs torchvision==0.24.0+cu129 to match torch==2.9.0+cu129). This update would break all backend-specific builds.
Dongxu-H
left a comment
There was a problem hiding this comment.
CI code-style check failed, need to check the failure details.
更新 torchvision 从厂商特定版本到通用版本 0.28.0 可能导致兼容性问题。metax 配置中 torch==2.8.0+metax3.7.2.0 搭配 torchvision==0.28.0 通用版本,iluvatar 配置中 torch==2.7.1+corex.4.4.0 搭配 torchvision==0.28.0 通用版本,这些组合可能无法正常工作。其他厂商如 kunlunxin、enflame、nvidia 等也存在类似问题。
移除厂商特定的 torchvision 构建版本可能丢失厂商优化功能,需要确认各厂商是否支持 torchvision 0.28.0 通用版本以及与当前 torch 版本的兼容性。
Bumps [torchvision](https://github.com/pytorch/vision) from 0.15.1+metax3.7.2.0 to 0.28.0. - [Release notes](https://github.com/pytorch/vision/releases) - [Commits](https://github.com/pytorch/vision/commits/v0.28.0) --- updated-dependencies: - dependency-name: torchvision dependency-version: 0.28.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
cd3f314 to
958cf80
Compare
Dongxu-H
left a comment
There was a problem hiding this comment.
CI code-style check failed, please check the failure details.
The PR removes backend-specific torchvision versions and uses a unified 0.28.0, but this may cause version incompatibility. torchvision 0.28.0 requires PyTorch 2.13.x, however many backends configure lower torch versions (e.g., torch==2.7.1 for iluvatar, torch==2.8.0 for metax-maca3720). Using torchvision 0.28.0 with these torch versions may lead to runtime errors.
Consider keeping backend-specific torchvision versions that match their torch versions, or verify compatibility for each backend before merging.
Dongxu-H
left a comment
There was a problem hiding this comment.
torchvision 0.28.0 is for PyTorch 2.12, but many backends use older torch versions (e.g., nvidia-cuda128 uses torch==2.10.0, metax-maca3720 uses torch==2.8.0). This may cause compatibility issues. torchvision version should align with the torch version for each backend. Consider keeping backend-specific torchvision versions or verifying compatibility with each backend's torch version.
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps torchvision from 0.15.1+metax3.7.2.0 to 0.28.0.
Release notes
Sourced from torchvision's releases.
... (truncated)
Commits