[KernelGen][MThreads] Add square_ Moore Threads specialized operator - #291
Open
Yukun-Cui wants to merge 1 commit into
Open
[KernelGen][MThreads] Add square_ Moore Threads specialized operator#291Yukun-Cui wants to merge 1 commit into
Yukun-Cui wants to merge 1 commit into
Conversation
Collaborator
|
/test | square_:mthreads |
❌ On-demand test failedOperator: The test failed to complete. Check the workflow run for details. |
Dongxu-H
reviewed
Aug 18, 2026
Dongxu-H
left a comment
Collaborator
There was a problem hiding this comment.
This PR contains 142 files with large infrastructure changes (CI workflows, CODEOWNERS deletions, benchmark modifications) mixed with the square_ operator implementation. This makes focused code review difficult. Consider splitting into separate PRs for operator implementation versus infrastructure changes. The square_ implementation in mthreads backend should be reviewed separately. Mthreads backend CI passes but the PR needs focused review on the operator-specific code which is buried in 142 files.
Yukun-Cui
force-pushed
the
pr/mthreads-square_
branch
from
August 19, 2026 03:38
662e248 to
2852f57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[KernelGen][MThreads] Add square_ Moore Threads specialized operator
Summary
Add a Moore Threads (MUSA) specialized Triton kernel for
square_, overriding the generic implementation viaruntime.replace_customized_ops(). Implements the square operation.Testing
tests/test_square.py(-m square_)GEMS_MTHREADS SQUARE_debug logPerformance
Compared against the generic FlagGems implementation on Moore Threads (MUSA).
square_
Files Changed
src/flag_gems/runtime/backend/_mthreads/ops/square_.py: Moore Threads Triton kernel + fallbacksrc/flag_gems/runtime/backend/_mthreads/ops/__init__.py: Register import and__all__