Skip to content

Add fft 1d OP - #1243

Closed
huangyiqun wants to merge 11 commits into
flagos-ai:masterfrom
huangyiqun:add_fft_1d
Closed

Add fft 1d OP#1243
huangyiqun wants to merge 11 commits into
flagos-ai:masterfrom
huangyiqun:add_fft_1d

Conversation

@huangyiqun

Copy link
Copy Markdown
Collaborator

PR Category

Operator

Type of Change

New Feature

Description

add 1d fft OP

Issue

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

20251219-162516

Comment thread src/flag_gems/ops/fft_1d.py Outdated
Comment thread src/flag_gems/ops/fft_1d.py Outdated
Comment thread src/flag_gems/ops/fft_1d.py
Comment thread src/flag_gems/ops/fft_1d.py Outdated
Comment thread src/flag_gems/ops/fft_1d.py Outdated
Comment thread src/flag_gems/ops/fft_1d.py Outdated
Comment thread src/flag_gems/ops/fft_1d.py Outdated
Comment thread src/flag_gems/ops/fft_1d.py Outdated
Comment thread tests/test_special_ops.py Outdated
tengqm
tengqm previously approved these changes Dec 29, 2025
@tengqm

tengqm commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

@huangyiqun Is it possible to squash your PR into a single commit?
See this blog for a reference.

Comment thread src/flag_gems/ops/__init__.py Outdated
@tengqm

tengqm commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

Are we supposed to register this into flag_gems/__init__.py as well?

@huangyiqun

Copy link
Copy Markdown
Collaborator Author

Are we supposed to register this into flag_gems/__init__.py as well?

The speedup ratio of this operator is relatively low, and its usage frequency in mainstream models is also quite low. Therefore, I think the necessity of replacing this operator needs further discussion.

@tengqm

tengqm commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

Are we supposed to register this into flag_gems/__init__.py as well?

The speedup ratio of this operator is relatively low, and its usage frequency in mainstream models is also quite low. Therefore, I think the necessity of replacing this operator needs further discussion.

Thanks for the confirmation.

@bin913

bin913 commented May 15, 2026

Copy link
Copy Markdown
Collaborator

@huangyiqun Do you still keep track of this PR?

@bin913 bin913 closed this May 18, 2026
@huangyiqun
huangyiqun deleted the add_fft_1d branch May 26, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants