add addcdiv.out, addcmul.out, baddbmm.out, cat.out etc; refactor op name according to native_functions.yaml - #2441
Conversation
tengqm
left a comment
tengqm
left a comment
There was a problem hiding this comment.
Please consider split this into several PRs, each with a single operator implemented along with test cases.
|
@taozhiwei Please help check the merge conflicts. |
|
@taozhiwei We are splitting the unit tests for easy of contributions and efficiency of CI pipeline. Sorry for the short-term inconvenience caused. Please help rebase this on to master. Thank you. |
9d9c072 to
9a02e2a
Compare
done |
…s-ai#2251) * [FlagGems Operator Development Competition] Add asinh operator * Drop inf edge cases from asinh test asinh(-inf) overflows in the log(x + sqrt(x^2+1)) form under fp16 and returns NaN, diverging from torch. The finite-value and NaN coverage is sufficient for the accuracy check. * Fix asinh NaN on -inf via sign(x)*log(|x|+sqrt(x^2+1)) The naive x + sqrt(x^2 + 1) form evaluates to -inf + inf = NaN when x = -inf, so the kernel returned NaN instead of -inf. Reformulating as sign(x) * log(|x| + sqrt(x^2 + 1)) uses magnitude in the log branch and restores the sign, matching torch.asinh across fp16/bf16/fp32 including the +/- inf edge cases. Restores inf and -inf to the edge-case test. --------- Co-authored-by: yunyiliu <yunyiliu@users.noreply.github.com> Co-authored-by: yunyiliu <genius00003@gmail.cm>
| "softmax", | ||
| "softmax_backward", | ||
| "softmax_backward_out", | ||
| "softmax_out", |
There was a problem hiding this comment.
I believe most of the newly added operators do not have corresponding benchmark added ...
4 participants
No description provided.