Rename 'name' field in op inventory to 'id' - #2681
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Operator
Type of Change
Refactor
Description
This PR renames the 'name' field in the
conf/operators.yamlfile toidto better reflect its actual usage. There are simply too many "name"s for an operator. The criteria we use to decide whether an operator is "new" is by checking if it is replacing a specific function in Torch (for aten operators). For fused operators, we treat an operator/operation as an unique item if it can be used independently.The
idfield is to be used in test cases for identifying an operator withpytest.mark.It is used to map to other operator lists maintained by our stakeholders.