[SiliconFlow] New Feat: Add vendor-aware skip_native marker for native baselines - #5436
Open
winfan1314 wants to merge 3 commits into
Open
[SiliconFlow] New Feat: Add vendor-aware skip_native marker for native baselines#5436winfan1314 wants to merge 3 commits into
skip_native marker for native baselines#5436winfan1314 wants to merge 3 commits into
Conversation
Signed-off-by: LinuxKiller <wangzixu13145687@gmail.com>
Signed-off-by: LinuxKiller <wangzixu13145687@gmail.com>
winfan1314
requested review from
0x45f,
103yiran,
Caeruleann,
bin913,
douxetpur,
hellojack163,
huangyiqun,
tengqm and
w1120029931-bit
as code owners
August 13, 2026 03:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Benchmark
Type of Change
New Feature
Description
This PR adds a function-level
skip_nativebenchmark marker:vendorsand a non-emptyreason, with invalid configurations reported during test setup.null/N/A, and emitsnative_baseline_skip_reasononly when the policy is active.--collect-marksoutput.tools/run_tests.pyandtools/psum_textto preserve Gems results and render skipped native metrics safely.unique_dimbenchmark variants on Ascend.tests/test_benchmark_skip_native.pyfor marker validation, execution behavior, serialization, parsing, and text summary coverage.When no
skip_nativemarker is active, benchmark execution, JSON schema, parser behavior, and text output remain unchanged. The ordinary parser and reporting outputs were compared against the pre-change implementation and are byte-identical.Validation:
absbenchmark: 1 passed; native latency, Gems latency, and speedup were all recorded, with no new JSON field.unique_dimbenchmark functions remained collected under-m "not skip_native".git diff --check: passed.Issue & PR
Progress
Note on
unique_dimThe
unique_dim-related changes are temporarily retained in this PR only to provide a real benchmark entry point for validating theskip_nativemechanism. They will be removed from this PR in a subsequent review update.The
unique_dimoperator fix and its updates are tracked separately in PR #5354.Performance
CANN 8.5 raw performance stdout
CANN 9.0 raw performance stdout