fix div_tensor_mode accuracy failure on mthreads backends - #5454
Merged
huangyiqun merged 1 commit intoAug 14, 2026
Merged
Conversation
lyujheng
requested review from
0x45f,
103yiran,
Caeruleann,
bin913,
douxetpur,
hellojack163,
huangyiqun,
tengqm and
w1120029931-bit
as code owners
August 13, 2026 10:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
OP Test
Type of Change
Bug Fix
Description
Changed accuracy test file of div_tensor_mode, relaxed
atolfrom1e-4to1.0fortest_div_tensor_mode_floatwhenrounding_modeistruncorfloor, reference runs on CPU (--ref cpu), and backend is mthreads.case:
When the quotient
a/bis extremely close to an integer boundary (e.g., 7.9999999 vs 8.0000001), a 1-ULP difference in float32 division between the mthreads GPU and CPU implementations gets amplified to ±1.0 aftertrunc/floortruncation. This is inherent floating-point behavior with discontinuous rounding functions, not an operator bug.Issue
N/A
Progress
Performance
Accuracy