Skip to content

【C++ Wrapper】add c++ wrapper for rope - #714

Merged
kiddyjinjin merged 4 commits into
flagos-ai:masterfrom
kiddyjinjin:more_wrapper
Jul 2, 2025
Merged

【C++ Wrapper】add c++ wrapper for rope#714
kiddyjinjin merged 4 commits into
flagos-ai:masterfrom
kiddyjinjin:more_wrapper

Conversation

@kiddyjinjin

Copy link
Copy Markdown
Collaborator

PR Category

Operator

Type of Change

New Feature

Description

add c++ wrapper for rope

Issue

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

@iclementine iclementine self-assigned this Jun 30, 2025
@StrongSpoon StrongSpoon self-assigned this Jun 30, 2025
StrongSpoon
StrongSpoon previously approved these changes Jul 1, 2025

@StrongSpoon StrongSpoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread lib/rotary_embedding.cpp Outdated
Comment thread lib/rotary_embedding.cpp Outdated
StrongSpoon
StrongSpoon previously approved these changes Jul 1, 2025

@StrongSpoon StrongSpoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@iclementine iclementine left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread lib/rotary_embedding.cpp Outdated
Comment thread include/flag_gems/operators.h Outdated

@zhzhcookie zhzhcookie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiddyjinjin
kiddyjinjin merged commit be6acf3 into flagos-ai:master Jul 2, 2025
0 of 5 checks passed
@kiddyjinjin
kiddyjinjin deleted the more_wrapper branch July 2, 2025 01:40
nicelynice pushed a commit to nicelynice/FlagGems that referenced this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants