Skip to content

support.tl.extra.shim.dispatch.to.backends - #727

Merged
Galaxy1458 merged 1 commit into
flagos-ai:masterfrom
kxyk99:support.tl.extra.shim.dispatch.to.backends
Jul 2, 2025
Merged

support.tl.extra.shim.dispatch.to.backends#727
Galaxy1458 merged 1 commit into
flagos-ai:masterfrom
kxyk99:support.tl.extra.shim.dispatch.to.backends

Conversation

@kxyk99

@kxyk99 kxyk99 commented Jul 1, 2025 •
edited by zhzhcookie
Loading

Copy link
Copy Markdown
Contributor

PR Category

UTILS

Type of Change

Bug Fix

Description

Issue

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

@zhzhcookie

zhzhcookie commented Jul 1, 2025

Copy link
Copy Markdown
Collaborator

Please use pre-commit to format the code.

@Galaxy1458

Galaxy1458 commented Jul 1, 2025

Copy link
Copy Markdown
Collaborator

Thank you for your contribution. Sorry, we forgot to provide the contribution guide. It needs to pass the code-format-check. FlagGems use pre-commit to manage code style. You can execute the following command to install and enable pre-commit
pip install pre-commit
pre-commit install
And you can read https://github.com/FlagOpen/FlagGems/blob/master/docs/code_countribution.md for more detail about countribution

@kxyk99
kxyk99 force-pushed the support.tl.extra.shim.dispatch.to.backends branch from d4e490e to dcdcd1c Compare July 1, 2025 08:49
Galaxy1458
Galaxy1458 reviewed Jul 1, 2025
View reviewed changes

@Galaxy1458 Galaxy1458 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Galaxy1458
Galaxy1458 reviewed Jul 1, 2025
View reviewed changes
Comment thread src/flag_gems/utils/triton_lang_extension.py


@triton.jit
@use_tl_extra

@Galaxy1458 Galaxy1458 Jul 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pointwise-op-test / container-unit-test failed

@triton.jit and @use_tl_extra might be necessary to change positions

@use_tl_extra
@triton.jit

@kxyk99 kxyk99 Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kxyk99
kxyk99 force-pushed the support.tl.extra.shim.dispatch.to.backends branch from dcdcd1c to 1b59941 Compare July 2, 2025 01:07
zhzhcookie
zhzhcookie approved these changes Jul 2, 2025
View reviewed changes

@zhzhcookie zhzhcookie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@Galaxy1458
Galaxy1458 merged commit 4b534e0 into flagos-ai:master Jul 2, 2025
8 of 14 checks passed
@Galaxy1458 Galaxy1458 mentioned this pull request Jul 2, 2025
Closed
nicelynice pushed a commit to nicelynice/FlagGems that referenced this pull request Feb 24, 2026
@kxyk99
support.tl.extra.shim.dispatch.to.backends (flagos-ai#727)
772be50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Galaxy1458 Galaxy1458 Galaxy1458 approved these changes
@zhzhcookie zhzhcookie zhzhcookie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AMD GPU extra-language ops import error

3 participants

@kxyk99 @zhzhcookie @Galaxy1458